-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Add system variable tidb_session_alias
to log a custom field session_alias
in session log
#46072
Conversation
2d7466a
to
39f02ff
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46072 +/- ##
================================================
- Coverage 74.7886% 72.7208% -2.0678%
================================================
Files 1297 1306 +9
Lines 398784 400621 +1837
================================================
- Hits 298245 291335 -6910
- Misses 81155 90790 +9635
+ Partials 19384 18496 -888
Flags with carried forward coverage won't be shown. Click here to find out more.
|
39f02ff
to
f0d997a
Compare
Co-authored-by: bb7133 <bb7133@gmail.com>
Co-authored-by: bb7133 <bb7133@gmail.com>
Co-authored-by: bb7133 <bb7133@gmail.com>
de537fd
to
0fe9e74
Compare
53399d1
to
0a6e2a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
/approve |
0a6e2a0
to
f5a6976
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, CbcWestwolf, easonn7, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@lcwangchao: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #46071
What is changed and how it works?
A new system variable
tidb_session_alias
with session scope is added. After this PR, we can trace some session in log identified by this field. for example:Some log will be printed and you can see session_alias in it.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.