Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: change PD tso rpc duration to higher percentile #45954

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Aug 9, 2023

What problem does this PR solve?

Issue Number: close #45953

Problem Summary: Change PD tso rpc duration to higher percentile.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. create a new cluster
  2. check the grafana
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 9, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #45954 (a740c25) into master (1b7a17e) will increase coverage by 0.1999%.
Report is 122 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45954        +/-   ##
================================================
+ Coverage   73.3467%   73.5467%   +0.1999%     
================================================
  Files          1277       1301        +24     
  Lines        393412     408997     +15585     
================================================
+ Hits         288555     300804     +12249     
- Misses        86453      89864      +3411     
+ Partials      18404      18329        -75     
Flag Coverage Δ
integration 26.8153% <ø> (?)
unit 74.2408% <ø> (+0.8940%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.2675% <ø> (+0.2180%) ⬆️
br 47.6420% <ø> (-4.3658%) ⬇️

@hawkingrei
Copy link
Member

/test all

1 similar comment
@hawkingrei
Copy link
Member

/test all

@jackysp jackysp requested a review from AndreMouche August 24, 2023 00:30
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndreMouche, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AndreMouche,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 24, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-09 14:06:26.52280784 +0000 UTC m=+121551.071823827: ☑️ agreed by hawkingrei.
  • 2023-08-24 01:31:26.755426834 +0000 UTC m=+1372251.304442806: ☑️ agreed by AndreMouche.

@ti-chi-bot ti-chi-bot bot merged commit 973e246 into pingcap:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the PD TSO RPC Duration to higher percentile
3 participants