Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: modify the physical proj elimination | tidb-test=pr/2145 #45224

Conversation

winoros
Copy link
Member

@winoros winoros commented Jul 6, 2023

What problem does this PR solve?

Issue Number: ref #45112

Problem Summary:

Don't let the physical projection elimination breaks the meaning of the UniqueID and the output columns.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 6, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@winoros winoros force-pushed the modify-physical-proj-elimination branch from 9ce760b to 84ac264 Compare July 10, 2023 12:09
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@winoros winoros force-pushed the modify-physical-proj-elimination branch from 84ac264 to 9b72fab Compare July 10, 2023 12:14
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@winoros winoros changed the title planner: modify the physical proj elimination planner: modify the physical proj elimination | tidb-test=pr/2145 Jul 10, 2023
@winoros
Copy link
Member Author

winoros commented Jul 10, 2023

/test mysql-test

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 10, 2023
@winoros
Copy link
Member Author

winoros commented Jul 10, 2023

/test mysql-test

@pingcap pingcap deleted a comment from tiprow bot Jul 10, 2023
@pingcap pingcap deleted a comment from tiprow bot Jul 10, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@winoros
Copy link
Member Author

winoros commented Jul 10, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Jul 10, 2023

@winoros: No presubmit jobs available for pingcap/tidb@release-6.5-20230425-v6.5.2

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 10, 2023
@winoros
Copy link
Member Author

winoros commented Jul 10, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Jul 10, 2023

@winoros: No presubmit jobs available for pingcap/tidb@release-6.5-20230425-v6.5.2

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-10 13:09:13.169382949 +0000 UTC m=+337444.939721662: ☑️ agreed by AilinKid.
  • 2023-07-10 14:07:58.42943079 +0000 UTC m=+340970.199769520: ☑️ agreed by time-and-fate.

@ti-chi-bot ti-chi-bot bot merged commit 07b7bbc into pingcap:release-6.5-20230425-v6.5.2 Jul 10, 2023
@winoros winoros deleted the modify-physical-proj-elimination branch July 10, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants