Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add switch for check constraint #44963

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44954

What problem does this PR solve?

Issue Number: ref #41711

Problem Summary:

What is changed and how it works?

Add switch for check constraint, the default setting is OFF

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add switch for check constraint.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot requested a review from a team as a code owner June 26, 2023 13:18
@ti-chi-bot ti-chi-bot added affects-7.2 ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.2 labels Jun 26, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 26, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, TonsnakeLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-26 13:21:06.376999441 +0000 UTC m=+627431.778249874: ☑️ agreed by TonsnakeLin.
  • 2023-06-26 13:23:49.804784457 +0000 UTC m=+627595.206034902: ☑️ agreed by qw4990.

@fzzf678
Copy link
Contributor

fzzf678 commented Jun 26, 2023

/retest

@fzzf678 fzzf678 changed the title sql: add switch for check constraint | tidb-test=pr/2160 (#44954) sql: add switch for check constraint (#44954) Jun 26, 2023
@fzzf678
Copy link
Contributor

fzzf678 commented Jun 26, 2023

/retest

@fzzf678 fzzf678 changed the title sql: add switch for check constraint (#44954) sql: add switch for check constraint | tidb-test=pr/2160 Jun 26, 2023
@fzzf678
Copy link
Contributor

fzzf678 commented Jun 26, 2023

/retest

1 similar comment
@fzzf678
Copy link
Contributor

fzzf678 commented Jun 26, 2023

/retest

@fzzf678
Copy link
Contributor

fzzf678 commented Jun 26, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Jun 26, 2023

@fzzf678: No presubmit jobs available for pingcap/tidb@release-7.2

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fzzf678 fzzf678 changed the title sql: add switch for check constraint | tidb-test=pr/2160 sql: add switch for check constraint Jun 26, 2023
@fzzf678
Copy link
Contributor

fzzf678 commented Jun 26, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 7e48b88 into pingcap:release-7.2 Jun 26, 2023
@wuhuizuo wuhuizuo deleted the cherry-pick-44954-to-release-7.2 branch August 18, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.2 approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants