Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: add parser support to PiTR #42826

Merged
merged 9 commits into from
Apr 10, 2023
Merged

parser: add parser support to PiTR #42826

merged 9 commits into from
Apr 10, 2023

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Apr 6, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #42825

Problem Summary:

What is changed and how it works?

SQL parser support to PiTR statement and backup metadata retrieval.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

This PR provides the SQL syntax support to PiTR statements and metadata retrieval.

@BornChanger
parser: add parser support to PitR
03e5a3d 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 6, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • YuJuncen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 6, 2023
@BornChanger
parser: move BR to NonKeyword section
e38eac8 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger BornChanger changed the title parser: add parser support to PitR parser: add parser support to PiTR Apr 6, 2023
@BornChanger
parser: avoid introducing any keywords
1bf9a42 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: save 1 more new token
40c52d3 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
parser: rename POINT to TO_POINT
7dd2538 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
Copy link
Contributor Author

/cc @YuJuncen

@ti-chi-bot ti-chi-bot requested a review from YuJuncen April 6, 2023 08:19
@BornChanger
Copy link
Contributor Author

/cc @3pointer

@ti-chi-bot ti-chi-bot requested a review from 3pointer April 6, 2023 08:19
@BornChanger
Copy link
Contributor Author

/cc @Leavrth

@ti-chi-bot ti-chi-bot requested a review from Leavrth April 6, 2023 08:19
BornChanger
BornChanger commented Apr 6, 2023
View reviewed changes
BornChanger
BornChanger commented Apr 6, 2023
View reviewed changes
CbcWestwolf
CbcWestwolf reviewed Apr 6, 2023
View reviewed changes
@BornChanger
parser: resolve 'POINT' issue
89ad1b5 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
parser: renanming
72f8e4f 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
parser: 2nd renaming
d371005 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
parser: parser.y code format
eaa31ea 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 10, 2023
YuJuncen
YuJuncen approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax change LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 10, 2023
@YuJuncen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eaa31ea

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 10, 2023
@YuJuncen
Copy link
Contributor

/merge

@BornChanger
Copy link
Contributor Author

/retest

1 similar comment
@BornChanger
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot merged commit 08085bc into pingcap:master Apr 10, 2023
@BornChanger BornChanger mentioned this pull request Apr 11, 2023
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

@Leavrth Leavrth Awaiting requested review from Leavrth

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BornChanger @ti-chi-bot @YuJuncen @CbcWestwolf @3pointer @Leavrth