Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: add NULL DEFINED BY and FORMAT to LOAD DATA #41332

Merged
merged 3 commits into from
Feb 15, 2023
Merged

parser: add NULL DEFINED BY and FORMAT to LOAD DATA #41332

merged 3 commits into from
Feb 15, 2023

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Feb 13, 2023 •
edited
Loading

Signed-off-by: lance6716 lance6716@gmail.com

What problem does this PR solve?

Issue Number: ref #40499

Problem Summary:

add parser support for NULL DEFINED BY

LOAD DATA ... [LINES ...] [NULL DEFINED BY <string> [OPTIONALLY ENCLOSED]] [IGNORE ...]

add parser support for FORMAT

LOAD DATA ... INFILE 'string' FORMAT 'string' ...

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716
parser: add NULL DEFINED BY to LOAD DATA
4aac6b0 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 13, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 13, 2023
@lance6716
Copy link
Contributor Author

/cc @gozssky @buchuitoudegou

@lance6716
add FORMAT
c5c4fef 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title parser: add NULL DEFINED BY to LOAD DATA parser: add NULL DEFINED BY and FORMAT to LOAD DATA Feb 13, 2023
@lance6716
Copy link
Contributor Author

ptal @gozssky @buchuitoudegou

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 15, 2023
sleepymole
sleepymole reviewed Feb 15, 2023
View reviewed changes
parser/parser.y Outdated
@@ -13970,6 +14013,30 @@ LinesTerminated:
$$ = $3
}

NullDef:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not resuse TextString?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3326462

@lance6716
address comment
3326462 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 15, 2023
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3326462

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 15, 2023
@lance6716
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot merged commit 8497f7d into pingcap:master Feb 15, 2023
ghazalfamilyusa pushed a commit to ghazalfamilyusa/tidb that referenced this pull request Feb 15, 2023
@lance6716 @ghazalfamilyusa
parser: add NULL DEFINED BY and FORMAT to LOAD DATA (pingcap#41332)
f7b036d 
ref pingcap#40499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@sleepymole sleepymole sleepymole approved these changes

@buchuitoudegou buchuitoudegou Awaiting requested review from buchuitoudegou

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-chi-bot @hawkingrei @sleepymole