Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support check constraint #41246

Closed

Conversation

CbcWestwolf
Copy link
Member

@CbcWestwolf CbcWestwolf commented Feb 9, 2023

What problem does this PR solve?

Issue Number: close #41711

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 9, 2023
@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 9, 2023
@CbcWestwolf
Copy link
Member Author

/test all

@CbcWestwolf
Copy link
Member Author

/retest-required

1 similar comment
@CbcWestwolf
Copy link
Member Author

/retest-required

@CbcWestwolf
Copy link
Member Author

/test unit-test
/test build
/test check_dev_2

@ti-chi-bot
Copy link
Member

@CbcWestwolf: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test unit-test
/test build
/test check_dev_2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CbcWestwolf
Copy link
Member Author

/test all

@CbcWestwolf
Copy link
Member Author

/test unit-test

@CbcWestwolf
Copy link
Member Author

/reopen

@ti-chi-bot ti-chi-bot reopened this Feb 23, 2023
@ti-chi-bot
Copy link
Member

@CbcWestwolf: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CbcWestwolf CbcWestwolf changed the title test: * *: support check constraint Feb 23, 2023
@CbcWestwolf
Copy link
Member Author

/test all

@CbcWestwolf
Copy link
Member Author

/retest

@CbcWestwolf CbcWestwolf closed this Apr 6, 2023
@CbcWestwolf CbcWestwolf force-pushed the check_constraint_master branch from 426ca58 to 61e1d81 Compare April 6, 2023 08:45
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 6, 2023
@CbcWestwolf CbcWestwolf deleted the check_constraint_master branch April 6, 2023 08:46
@pingcap pingcap deleted a comment from ti-chi-bot Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CHECK constraint
2 participants