-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: check write stall when switch-mode is disabled #40116
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
263da56
to
6618c4d
Compare
/hold Need to think about how to add tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test is added in #40228
@lance6716 It seems this PR can be replaced by #40228. I will close this PR. Please update the title and description of #40228. |
What problem does this PR solve?
Issue Number: close #40163
Problem Summary:
Although TiKV checks write stall before ingesting, it doesn't work on the follower node of the region. https://github.com/tikv/tikv/blob/8864e9bac814554bbe4acaddd01282f5fdae3dae/src/import/sst_service.rs#L181. To avoid write stall on follower node, Lightning should also check write stall before ingesting data to each peer of the region.
What is changed and how it works?
When swtich-mode is disabled, we assume Lightning is importing to data to an online cluster. Then before ingesting, use an empty
MultiIngestRequest
to check whether ingesting may cause write stall on every peer of the region.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.