-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: enable foreign_key_checks variable by default #39695
*: enable foreign_key_checks variable by default #39695
Conversation
Signed-off-by: crazycs520 <crazycs520@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
/run-all-tests tidb-test=pr/2038 |
/run-all-tests tidb-test=pr/2038 |
/run-all-tests tidb-test=pr/2038 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: bff6ea7
|
/run-all-tests tidb-test=pr/2038 |
/run-all-tests tidb-test=pr/2038 |
TiDB MergeCI notify🔴 Bad News! [2] CI still failing after this pr merged.
|
Signed-off-by: crazycs520 crazycs520@gmail.com
What problem does this PR solve?
Issue Number: close #39694
Problem Summary: The default value of
foreign_key_checks
in MySQL istrue
, but TiDB isfalse
. Since TiDB already supported foreign key, PM @easonn7 thinks the default value offoreign_key_checks
should be consistent with MySQL.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.