-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: skip the error when fallback from ingest to txn method #39360
ddl: skip the error when fallback from ingest to txn method #39360
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-check_dev_2 |
/run-check_dev_2 |
/run-check_dev_2 |
/run-check_dev_2 |
2 similar comments
/run-check_dev_2 |
/run-check_dev_2 |
…n2037/tidb into fix-default-on-fast-ddl-ut-part1
/run-all-tests |
/run-all-tests |
1 similar comment
/run-all-tests |
/run-build |
/run-mysql-test |
/merge |
@Benjamin2037: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ebc9852
|
TiDB MergeCI notify🔴 Bad News! [1] CI still failing after this pr merged.
|
What problem does this PR solve?
Issue Number: ref #39321
Problem Summary:
When set fast reorg variable on, some ut will failed.
What is changed and how it works?
This four case is dur to pd create rollback DDL, we set err to nil and DDL task will be resumed and executed later
skip merge woker number checker.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.