Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add debug log for analyze #39357

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Nov 24, 2022

Signed-off-by: yisaer disxiaofei@163.com

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and how it works?

add debug log for analyze

mysql> CREATE TABLE t (a int, b int, index idx(b))
    -> PARTITION BY RANGE ( a ) (
    ->   PARTITION p0 VALUES LESS THAN (6),
    ->   PARTITION p1 VALUES LESS THAN (11)
    -> );
Query OK, 0 rows affected (0.02 sec)

mysql> set @@tidb_build_stats_concurrency=1;
Query OK, 0 rows affected (0.00 sec)

mysql> analyze table t;
Query OK, 0 rows affected, 2 warnings (0.10 sec)
[2022/11/24 13:37:26.118 +08:00] [INFO] [analyze_col_v2.go:213] ["merge subCollector in concurrency in AnalyzeColumnsExecV2"] [tableID=87] [partitionID=88] [isPartitionTable=true] [oldRootCount=0] [newRootCount=1] [subCount=1] [subCollectorIndex=0]
[2022/11/24 13:37:26.118 +08:00] [INFO] [analyze_col_v2.go:205] ["merge subMergeWorker in AnalyzeColumnsExecV2"] [tableID=87] [partitionID=88] [isPartitionTable=true] [oldRootCount=0] [newRootCount=1] [subCount=1]
[2022/11/24 13:37:26.119 +08:00] [INFO] [analyze_col_v2.go:213] ["merge subCollector in concurrency in AnalyzeColumnsExecV2"] [tableID=87] [partitionID=89] [isPartitionTable=true] [oldRootCount=0] [newRootCount=1] [subCount=1] [subCollectorIndex=0]
[2022/11/24 13:37:26.119 +08:00] [INFO] [analyze_col_v2.go:205] ["merge subMergeWorker in AnalyzeColumnsExecV2"] [tableID=87] [partitionID=89] [isPartitionTable=true] [oldRootCount=0] [newRootCount=1] [subCount=1]
[2022/11/24 13:37:26.120 +08:00] [INFO] [handle.go:1690] ["[stats] incrementally update modifyCount"] [tableID=88] [curModifyCnt=0] [results.BaseModifyCnt=0] [modifyCount=0]
[2022/11/24 13:37:26.120 +08:00] [INFO] [handle.go:1712] ["[stats] directly update count"] [tableID=88] [results.Count=1] [count=1]
[2022/11/24 13:37:26.134 +08:00] [INFO] [analyze.go:587] ["analyze table `test`.`t` has finished"] [partition=p0] ["job info"="analyze table all columns with 256 buckets, 500 topn, 1 samplerate"] ["start time"=2022/11/24 13:37:26.115 +08:00] ["end time"=2022/11/24 13:37:26.134 +08:00] [cost=18.846254ms]
[2022/11/24 13:37:26.135 +08:00] [INFO] [handle.go:1690] ["[stats] incrementally update modifyCount"] [tableID=89] [curModifyCnt=0] [results.BaseModifyCnt=0] [modifyCount=0]
[2022/11/24 13:37:26.135 +08:00] [INFO] [handle.go:1712] ["[stats] directly update count"] [tableID=89] [results.Count=1] [count=1]
[2022/11/24 13:37:26.148 +08:00] [INFO] [analyze.go:587] ["analyze table `test`.`t` has finished"] [partition=p1] ["job info"="analyze table all columns with 256 buckets, 500 topn, 1 samplerate"] ["start time"=2022/11/24 13:37:26.118 +08:00] ["end time"=2022/11/24 13:37:26.148 +08:00] [cost=29.650575ms]

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: yisaer <disxiaofei@163.com>
Signed-off-by: yisaer <disxiaofei@163.com>
@Yisaer Yisaer added the skip-issue-check Indicates that a PR no need to check linked issue. label Nov 24, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2022
@Yisaer Yisaer marked this pull request as ready for review November 24, 2022 05:52
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 24, 2022
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6bc2d9b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 24, 2022
@ti-chi-bot
Copy link
Member

@Yisaer: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 4a91a24 into pingcap:master Nov 24, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 24, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [2] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 9 min 8 sec Existing failure
idc-jenkins-ci-tidb/sqllogic-test-2 ✅ all 28 tests passed 31 min Fixed
idc-jenkins-ci/integration-cdc-test ✅ all 39 tests passed 23 min Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 38 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 55 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 0 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants