-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: modify collate.newCollationEnabled according to the config of the cluster (#39173) #39319
br: modify collate.newCollationEnabled according to the config of the cluster (#39173) #39319
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
… cluster Signed-off-by: MoCuishle28 <zhanggaoming028@gmail.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 69abddf
|
/run-all-tests |
/run-mysql-test |
/run-check_dev |
/run-mysql-test |
/run-build |
/run-mysql-test |
1 similar comment
/run-mysql-test |
/run-check_dev |
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-check_dev |
/run-unit-test |
/run-check_dev |
/run-check_dev |
This is an automated cherry-pick of #39173
What problem does this PR solve?
Issue Number: close #39150
Problem Summary:
The
collate.newCollationEnabled
variable is set to 1 when the collate package is initialized. When using this package, this value is not modified according to the config of the TiDB cluster (i.e.,new_collations_enabled_on_first_bootstrap
).As a result, the user sets
new_collations_enabled_on_first_bootstrap
tofalse
in the TiDB cluster, and it is still treated astrue
when br is executed.What is changed and how it works?
Modify
collate.newCollationEnabled
according to the config of the cluster.Check List
Tests
Side effects
Documentation
Manual test
new_collations_enabled_on_first_bootstrap: false
.create table books (id bigint auto_increment,name varchar(64), primary key (id)) CHARSET utf8mb4 COLLATE utf8mb4_0900_ai_ci
;new_collations_enabled_on_first_bootstrap: false
.Release note
Please refer to Release Notes Language Style Guide to write a quality release note.