util: change record analyze to explain in oom alarm #39099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d970c9b.
…n memory usage alarm (pingcap#38729)" This reverts commit ba175c4.
…gcap#38727)" This reverts commit a151383.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
XuHuaiyu
approved these changes
Nov 13, 2022
|
/rebuild |
|
/run-all-tests |
hawkingrei
approved these changes
Nov 13, 2022
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 2f1d2ec
|
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: f4daba4
|
12 tasks
|
In response to a cherrypick label: new pull request created: #39100. |
TiDB MergeCI notify🔴 Bad News! New failing [2] after this pr merged.
|
ti-chi-bot
added a commit
that referenced
this pull request
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #39036 #39094 #39098
Problem Summary:
What is changed and how it works?
At present, method plannercore.GetExplainAnalyzeRowsForPlan is called only after the sql is executed
Because method plannercore.GetExplainAnalyzeRowsForPlan() was previously called only after the sql was executed, concurrency was not considered. If method plannercore.GetExplainAnalyzeRowsForPlan() is called during sql execution, there will be a lot of panic associated with concurrent map and it will be difficult to handle, so we will only record the plan to solve this problem.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.