Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: push order to partition table and configure concurrency for auto analyze #38722

Merged
merged 3 commits into from
Oct 28, 2022
Merged

*: push order to partition table and configure concurrency for auto analyze #38722

merged 3 commits into from
Oct 28, 2022

Conversation

winoros
Copy link
Member

@winoros winoros commented Oct 28, 2022

What problem does this PR solve?

Issue Number: ref #36108 and #37078

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@winoros
Squashed commit of the following:
c56d702 
commit 51853c7
Author: Yiding Cui <winoros@gmail.com>
Date:   Fri Oct 28 11:25:16 2022 +0800

    fix

commit bdf9854
Merge: 27324cb fb6a131
Author: Yiding Cui <winoros@gmail.com>
Date:   Fri Oct 28 11:08:16 2022 +0800

    Merge branch 'master' into part-table-topn

commit 27324cb
Author: Yiding Cui <winoros@gmail.com>
Date:   Sun Aug 28 22:55:37 2022 +0800

    fix test

commit 174254c
Merge: 4b00f0a a8f524b
Author: Yiding Cui <winoros@gmail.com>
Date:   Sun Aug 28 22:24:10 2022 +0800

    Merge branch 'master' into part-table-topn

commit 4b00f0a
Merge: 027eca6 5006949
Author: Yiding Cui <winoros@gmail.com>
Date:   Sun Aug 28 15:10:27 2022 +0800

    Merge remote-tracking branch 'yiding/part-table-topn' into part-table-topn

commit 027eca6
Author: Yiding Cui <winoros@gmail.com>
Date:   Sun Aug 28 15:09:58 2022 +0800

    fix tests

commit 5006949
Merge: 0575b4c 2858bc1
Author: Yiding Cui <winoros@gmail.com>
Date:   Fri Aug 26 15:32:26 2022 +0800

    Merge branch 'master' into part-table-topn

commit 0575b4c
Author: Yiding Cui <winoros@gmail.com>
Date:   Fri Aug 26 15:06:33 2022 +0800

    fix lint

commit af0cf54
Merge: 2bc49ff b99aebe
Author: Yiding Cui <winoros@gmail.com>
Date:   Fri Aug 26 14:48:26 2022 +0800

    Merge branch 'master' into part-table-topn

commit 2bc49ff
Author: Yiding Cui <winoros@gmail.com>
Date:   Wed Jul 20 17:30:06 2022 +0800

    fix make check

commit f940c71
Author: Yiding Cui <winoros@gmail.com>
Date:   Wed Jul 20 17:23:51 2022 +0800

    make sure that the request is sent first by partition then by region

commit 423f599
Author: Yiding Cui <winoros@gmail.com>
Date:   Wed Jul 20 01:40:45 2022 +0800

    add tests

commit 6ccdc30
Merge: 9f57b9c 39bca97
Author: Yiding Cui <winoros@gmail.com>
Date:   Tue Jul 19 19:53:20 2022 +0800

    Merge remote-tracking branch 'yiding/part-table-topn' into part-table-topn

commit 9f57b9c
Author: Yiding Cui <winoros@gmail.com>
Date:   Tue Jul 19 01:08:00 2022 +0800

    address comments

commit 896a4e0
Merge: 2c08dde 4cade24
Author: Yiding Cui <winoros@gmail.com>
Date:   Mon Jul 18 17:47:49 2022 +0800

    Merge branch 'master' into part-table-topn

commit 39bca97
Merge: 2c08dde a33d971
Author: Weizhen Wang <wangweizhen@pingcap.com>
Date:   Sat Jul 16 11:27:13 2022 +0800

    Merge branch 'master' into part-table-topn

commit 2c08dde
Author: Yiding Cui <winoros@gmail.com>
Date:   Wed Jul 13 20:30:23 2022 +0800

    add tests

commit 3106166
Author: Yiding Cui <winoros@gmail.com>
Date:   Mon Jul 11 23:13:22 2022 +0800

    fix fmt

commit 3993e00
Author: Yiding Cui <winoros@gmail.com>
Date:   Mon Jul 11 23:12:00 2022 +0800

    planner: support push part of order property to partition table

commit 7c9e327
Author: Yiding Cui <winoros@gmail.com>
Date:   Thu Jul 7 17:37:59 2022 +0800

    planner: support push part of order property down to the partition table
@winoros
cherry pick pingcap#37078
10e6c4e
@winoros winoros requested a review from a team as a code owner October 28, 2022 09:11
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • chrysan
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 28, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 28, 2022
chrysan
chrysan previously approved these changes Oct 28, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 28, 2022
time-and-fate
time-and-fate reviewed Oct 28, 2022
View reviewed changes
executor/adapter.go
Comment on lines +463 to +474
autoConcurrency, err1 := sctx.GetSessionVars().GetSessionOrGlobalSystemVar(variable.TiDBAutoBuildStatsConcurrency)
terror.Log(err1)
if err1 == nil {
terror.Log(sctx.GetSessionVars().SetSystemVar(variable.TiDBBuildStatsConcurrency, autoConcurrency))
}
sVal, err2 := sctx.GetSessionVars().GetSessionOrGlobalSystemVar(variable.TiDBSysProcScanConcurrency)
terror.Log(err2)
if err2 == nil {
concurrency, err3 := strconv.ParseInt(sVal, 10, 64)
terror.Log(err3)
sctx.GetSessionVars().SetDistSQLScanConcurrency(int(concurrency))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this location is wrong. It should replace the original SetDistSQLScanConcurrency.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 28, 2022
@winoros
Copy link
Member Author

winoros commented Oct 28, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c337fc9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 28, 2022
@ti-chi-bot ti-chi-bot merged commit 240708f into pingcap:release-6.3-20221028-v6.3.0 Oct 28, 2022
chrysan pushed a commit to chrysan/tidb that referenced this pull request Nov 21, 2022
@winoros @chrysan
*: push order to partition table and configure concurrency for auto a…
3a80ba0 
…nalyze (pingcap#38722)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@chrysan chrysan chrysan left review comments

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@winoros @ti-chi-bot @chrysan @time-and-fate @sre-bot