-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: create a user using tidb_auth_token
authentication
#38585
Merged
Merged
Changes from 10 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
7f6f17f
Create user with `tidb_auth_token`
CbcWestwolf d21fab3
Add test for create user
CbcWestwolf 28b9548
Merge branch 'master' into tidb_auth_token
CbcWestwolf 7be6f51
Fix UT
CbcWestwolf ca7a000
Support `token_require` and `token_issuer`
CbcWestwolf a1e3c5f
show create user
CbcWestwolf d559001
bazel
CbcWestwolf ab25f46
Fix UT
CbcWestwolf 10476c2
Add more test
CbcWestwolf 13a4b0f
Merge branch 'master' of github.com:pingcap/tidb into tidb_auth_token
CbcWestwolf c50c762
Update
CbcWestwolf 241aea7
Add warning while specifying `token_require` for other auth
CbcWestwolf 16a8ec5
Fix parser
CbcWestwolf a5adcf7
Fix
CbcWestwolf 23156c9
Fix
CbcWestwolf a2b0cf9
Fix UT
CbcWestwolf 13c7567
Merge branch 'master' into tidb_auth_token
CbcWestwolf 536ec01
Add more warnings
CbcWestwolf dd8b19a
Merge TLSOption and AuthTokenOption into AuthTokenOrTLSOption
CbcWestwolf 01d21df
Merge branch 'tidb_auth_token' of github.com:CbcWestwolf/tidb into ti…
CbcWestwolf ff20723
Update
CbcWestwolf b09987b
Merge branch 'tidb_auth_token' of github.com:CbcWestwolf/tidb into ti…
CbcWestwolf b3034f4
Merge branch 'master' of github.com:pingcap/tidb into tidb_auth_token
CbcWestwolf c39474b
Merge branch 'master' of github.com:pingcap/tidb into tidb_auth_token
CbcWestwolf 50b54bd
Fix build
CbcWestwolf a758fb6
Update
CbcWestwolf daed722
Rename
CbcWestwolf b2f1d75
Apply suggestions from code review
CbcWestwolf 5f3294d
Update
CbcWestwolf 340811b
Update UT
CbcWestwolf ffc937c
Merge branch 'master' into tidb_auth_token
ti-chi-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it allowed to specify token_issuer for other auth plugins in create user or alter user statements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the specified
token_issuer
is stored intomysql.user
for all users. But it would not affect the authentication of the other auth plugin usersThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, if a user is identified with
mysql_native_password
, and the root user alters his token_issuer, this is meaningless. Should we report an error?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can give a warning when
create user
/alter user
meet such a scenario.