Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: set tiflash placement group index to 120 (#37179) #38476

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #37179

What problem does this PR solve?

Issue Number: ref #37171

What is changed and how it works?

  1. Set the group_index of placement rule group 'tiflash' to 120 when adding a tiflash placement rule.
  2. Fix the group_index in PollTiFlashRoutine when the background task started for old cluster.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Manual test1:

  1. Create a table with tiflash replica in the old cluster.
  2. Upgrade one tidb instance of the cluster to the code of this PR, the tiflash group_index was fixed to 120.

Manual test2:

  1. Setup a new cluster with the code of this PR.
  2. Create a new table with tiflash replica, the tiflash group_index is 120.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Oct 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Oct 14, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Oct 14, 2022
@lcwangchao lcwangchao requested review from xhebox and bb7133 October 14, 2022 11:47
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 14, 2022
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 14, 2022
@lcwangchao
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 399bab2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2022
@xhebox
Copy link
Contributor

xhebox commented Oct 14, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit 544e759 into pingcap:release-6.1 Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants