Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: implement json time/duration #37579

Merged
merged 4 commits into from
Sep 8, 2022
Merged

executor: implement json time/duration #37579

merged 4 commits into from
Sep 8, 2022

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Sep 2, 2022 •
edited
Loading

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

Issue Number: close #9988, close #31104

Problem Summary:

The TiDB doesn't distinguish the DATETIME/DATE/TIMESTAMP/TIME and STRING.

What is changed and how it works?

Based on #37578

I added four types of JSON: DATETIME/DATE/TIMESTAMP/TIME, and the cast between them and the Time/Duration.

Check List

Tests

TODO

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Fix the issue that TiDB doesn't distinguish the `DATETIME/DATE/TIMESTAMP/TIME` and `STRING` in json type.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 2, 2022
This was referenced Sep 5, 2022
Closed
Merged
@YangKeao YangKeao force-pushed the fix-9988 branch 5 times, most recently from 3094a93 to 70cd5a8 Compare September 5, 2022 11:47
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 5, 2022
@YangKeao
Copy link
Member Author

YangKeao commented Sep 5, 2022

/run-mysql-test tidb-test=pr/1960

@YangKeao
Copy link
Member Author

YangKeao commented Sep 5, 2022

/run-mysql-test tidb-test=pr/1960

@YangKeao YangKeao marked this pull request as ready for review September 5, 2022 14:09
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2022
@YangKeao
Copy link
Member Author

YangKeao commented Sep 5, 2022

/run-mysql-test tidb-test=pr/1960

@YangKeao
Copy link
Member Author

YangKeao commented Sep 6, 2022

PTAL @xiongjiwei

@YangKeao
Copy link
Member Author

YangKeao commented Sep 6, 2022

/run-mysql-test tidb-test=pr/1960

@YangKeao
Copy link
Member Author

YangKeao commented Sep 6, 2022

/run-mysql-test tidb-test=pr/1960

xiongjiwei
xiongjiwei reviewed Sep 6, 2022
View reviewed changes
@YangKeao
Copy link
Member Author

YangKeao commented Sep 6, 2022

/run-mysql-test tidb-test=pr/1960

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2022
@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2022

@xhebox PTAL

@YangKeao YangKeao force-pushed the fix-9988 branch 2 times, most recently from cac234e to 737d2fe Compare September 8, 2022 06:45
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 8, 2022
@xhebox
Copy link
Contributor

xhebox commented Sep 8, 2022

@YangKeao Some tests may be related

  ✘  https://revive.run/r#exported  exported var JSONZero should have comment or be unexported  

新的故障 - 2
TestIssue1223 – expression2s
TestToBool – types

@YangKeao
implement json time/duration
90f7e3f 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2022

/run-mysql-test tidb-test=pr/1960

@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2022

/merge

@ti-chi-bot
Copy link
Member

@YangKeao: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2022

@YangKeao Some tests may be related

  ✘  https://revive.run/r#exported  exported var JSONZero should have comment or be unexported  

新的故障 - 2
TestIssue1223 – expression2s
TestToBool – types

Fixed 🍻

@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2022

/run-mysql-test tidb-test=pr/1960

@xhebox
Copy link
Contributor

xhebox commented Sep 8, 2022

/merge
/run-mysql-test tidb-test=pr/1960

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 90f7e3f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 8, 2022
@xhebox
Copy link
Contributor

xhebox commented Sep 8, 2022

/run-mysql-test tidb-test=pr/1960

2 similar comments
@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2022

/run-mysql-test tidb-test=pr/1960

@YangKeao
Copy link
Member Author

YangKeao commented Sep 8, 2022

/run-mysql-test tidb-test=pr/1960

@ti-chi-bot ti-chi-bot merged commit cdcbfc8 into pingcap:master Sep 8, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 8, 2022

TiDB MergeCI notify

🔴 Bad News! [3] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 15, total 17 18 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 15 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 12 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 12 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 55 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 3 min 57 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 24 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 6 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
5 participants
@YangKeao @ti-chi-bot @xhebox @sre-bot @xiongjiwei