Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: append warning for sorting non-scalar json value #37544

Closed
wants to merge 1 commit into from

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Sep 1, 2022

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

Issue Number: close #37506

Problem Summary:

TiDB doesn't report a warning for non-scalar json sort.

Append warning while sorting a non-scalar json value.

What is changed and how it works?

The json comparater will report a warning for non-scalar json value (e.g. json array and json object), so does the

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Fix the issue that sorting non-scalar json value doesn't report the warning

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Sep 1, 2022
@YangKeao YangKeao changed the title append warning for sorting non-scalar json value executor: append warning for sorting non-scalar json value Sep 1, 2022
if lNull || rNull {
return cmpNull(lNull, rNull)
func getCmpJSONFunction(wp WarningReporter) CompareFunc {
// TODO: deduplicate the warning in a wider range
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could compare against all warnings inside the sctx to check whether this warning is duplicated, but I'm not sure whether it's necessary.

@YangKeao YangKeao requested a review from xiongjiwei September 1, 2022 07:27
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member Author

YangKeao commented Sep 1, 2022

Close because #37506 (comment)

@YangKeao YangKeao closed this Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

order by of json value is different with MySQL
2 participants