Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: use a relax json comparison cast rule #37404

Merged
merged 2 commits into from
Aug 31, 2022
Merged

expression: use a relax json comparison cast rule #37404

merged 2 commits into from
Aug 31, 2022

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Aug 26, 2022 •
edited
Loading

Signed-off-by: YangKeao yangkeao@chunibyo.icu

What problem does this PR solve?

Issue Number: close #37403

Problem Summary:

What is changed and how it works?

If one of the compare args is json value, the other should be casted to json.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
select cast('{ }' as json) < 1;

Release note

Fix the issue that the comparison between json and other value is not compatible with MySQL

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2022
@YangKeao YangKeao marked this pull request as draft August 26, 2022 08:33
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2022
@ngaut
Copy link
Member

ngaut commented Aug 27, 2022

Please add test cases.

@YangKeao YangKeao mentioned this pull request Aug 29, 2022
Open
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 29, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 29, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/de52e2800c7db453774aef0817021f42802a5a88

@YangKeao
Copy link
Member Author

YangKeao commented Aug 29, 2022 •
edited
Loading

/tests

@YangKeao YangKeao force-pushed the fix-37403 branch 2 times, most recently from f4df2bf to b01b673 Compare August 30, 2022 10:29
@YangKeao
Copy link
Member Author

/run-mysql-test tidb-test=pr/1951

1 similar comment
@YangKeao
Copy link
Member Author

/run-mysql-test tidb-test=pr/1951

@YangKeao YangKeao mentioned this pull request Aug 30, 2022
Closed
@YangKeao
Copy link
Member Author

/run-mysql-test tidb-test=pr/1951

1 similar comment
@YangKeao
Copy link
Member Author

/run-mysql-test tidb-test=pr/1951

@YangKeao
use a relax json comparison cast rule
de52e28 
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
@YangKeao
Copy link
Member Author

/run-mysql-test tidb-test=pr/1951

1 similar comment
@xiongjiwei
Copy link
Contributor

/run-mysql-test tidb-test=pr/1951

@YangKeao YangKeao marked this pull request as ready for review August 31, 2022 07:04
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2022
@xiongjiwei
Copy link
Contributor

/cc @xhebox

@ti-chi-bot ti-chi-bot requested a review from xhebox August 31, 2022 07:05
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 31, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 31, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: de52e28

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 31, 2022
@xiongjiwei
Copy link
Contributor

/run-mysql-test tidb-test=pr/1951

1 similar comment
@xiongjiwei
Copy link
Contributor

/run-mysql-test tidb-test=pr/1951

@xiongjiwei
Copy link
Contributor

/run-build

1 similar comment
@xiongjiwei
Copy link
Contributor

/run-build

@xhebox
Copy link
Contributor

xhebox commented Aug 31, 2022

/merge
/run-mysql-test tidb-test=pr/1951

@ti-chi-bot ti-chi-bot merged commit d46da50 into pingcap:master Aug 31, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 31, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 5, success 12, total 17 16 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 2, success 9, total 11 13 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 31 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 9 min 21 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 30 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 0 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 31 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 29 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 51 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cast other types to JSON when compared with JSON value
6 participants
@YangKeao @ti-chi-bot @ngaut @xiongjiwei @xhebox @sre-bot