Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: set EnableOuterJoinReorder to false by default (#37264) #37281

Merged
merged 2 commits into from
Aug 22, 2022
Merged

planner: set EnableOuterJoinReorder to false by default (#37264) #37281

merged 2 commits into from
Aug 22, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 22, 2022 •
edited
Loading

cherry-pick #37264 to release-6.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/37281

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/37281:release-6.2-21847fe58b51

What problem does this PR solve?

Issue Number: ref #37238

Problem Summary:

What is changed and how it works?

Set it to false by default.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@winoros @ti-srebot
cherry pick pingcap#37264 to release-6.2
9722592 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner August 22, 2022 11:32
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • chrysan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 22, 2022
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 22, 2022
@ti-srebot ti-srebot mentioned this pull request Aug 22, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/6.2-cherry-pick labels Aug 22, 2022
@ti-srebot ti-srebot requested review from chrysan, fixdb and qw4990 August 22, 2022 11:32
@ti-srebot
Copy link
Contributor Author

@winoros you're already a collaborator in bot's repo.

@winoros
Copy link
Member

winoros commented Aug 22, 2022

/run-mysql-test tidb-test=pr/1935

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 22, 2022
@winoros
Copy link
Member

winoros commented Aug 22, 2022

/run-mysql-test tidb-test=pr/1935

@sre-bot
Copy link
Contributor

sre-bot commented Aug 22, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c866201e72c750a6d0ef5792ca5ec0a23ae25f5b

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 22, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 22, 2022
@chrysan
Copy link
Contributor

chrysan commented Aug 22, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c866201

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 22, 2022
@jebter
Copy link

jebter commented Aug 22, 2022

/run-mysql-test

@jebter
Copy link

jebter commented Aug 22, 2022

/run-mysql-test tidb-test=pr/1935

@ti-chi-bot ti-chi-bot merged commit daf2b17 into pingcap:release-6.2 Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrysan chrysan chrysan approved these changes

@qw4990 qw4990 qw4990 approved these changes

@AilinKid AilinKid AilinKid approved these changes

@fixdb fixdb Awaiting requested review from fixdb

Assignees

@winoros winoros

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.2-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @ti-chi-bot @winoros @sre-bot @chrysan @jebter @qw4990 @AilinKid