-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix the order of FallbackOldAndSetNewAction
#37272
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
c1c293b
to
e5d938a
Compare
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
FallbackOldAndSetNewAction
FallbackOldAndSetNewAction
Signed-off-by: YangKeao <yangkeao@chunibyo.icu>
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3c535ef3bc7901fea3cd2fd9d2d98172fb12b31c |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 89ed0e9
|
/run-mysql-test tidb-test=pr/1937 |
TiDB MergeCI notify🔴 Bad News! [2] CI still failing after this pr merged.
|
Signed-off-by: YangKeao yangkeao@chunibyo.icu
What problem does this PR solve?
Issue Number: close #37058
Problem Summary:
FallbackOldAndSetNewAction
is wrong. It should set the current action to the new one, and set the original one as its fallback (as how it's used, and described in the comments). However, it acts in the opposite way now 🤦 , and cause the unstable test.What is changed and how it works?
I rearrange the arguments order of the
FallbackOldAndSetNewAction
Check List
Tests
I manually, repeatedly run this test multiple times (in parallel, 32 jobs) for several minutes, and it seems that it's stable now ❤️ .
Release note