-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightning: fix incorrect parse tidb release version #37227
Lightning: fix incorrect parse tidb release version #37227
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/71306d15746514c0ace55ad26a06884e8b938652 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-integration-br-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
/run-integration-br-test |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 29a9241
|
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
…ingcap#37227)"" This reverts commit 3b313df.
What problem does this PR solve?
this PR resolved parallel import conflict caused by unexpected output from tidb_version() return.
Issue Number: close #37007
Problem Summary:
tidb version number cause parallel import conflict records
What is changed and how it works?
In the FetchVersion function, I added a precheck for querying the results of the tidb_version() function before it returns.
If querying results didn't match a pattern of Release Version: v, then there are no valid release versions that will be parsed by ParseServerInfo. it should turn into fall back and return the result from select version()
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.