Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: support HashJoin cost detail #37012
planner: support HashJoin cost detail #37012
Changes from 9 commits
d9e1d63
0b5da58
4ec704f
a8a5008
ec4e376
a3965be
62f941e
6c4eeeb
e64f93c
b795817
fb38188
24172a1
4798b92
f3a4fbe
62040c2
f1b6216
369255c
cc901c0
e44ec89
6adc272
8e2ab75
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that in previous PRs, each label in the
Desc
corresponds to exactly one value in theParam
with the same label. But this PR doesn't follow this.For example, we didn't explain the relationship between
CPUCostDetailLbl
,CPUCostDescLbl
, andProbeCostDescLbl
.Would we improve this sometime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently no, we may ignore this in interval server and revise it in dashboard.