Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add binary plan in stmt summary and slow log/query #35698

Merged
merged 91 commits into from
Jul 20, 2022
Merged

*: add binary plan in stmt summary and slow log/query #35698

merged 91 commits into from
Jul 20, 2022

Conversation

time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Jun 23, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #35889

What is changed and how it works?

  • Add a field into stmtCtx to cache the binary plan.
  • Add a field into the SlowQueryLogItems that contains the binary plan.
  • Output the binary plan to the slow log in the format of Binary_plan: tidb_decode_binary_plan('xxx')
  • Add a field into the stmtSummaryByDigestElement that contains the binary plan.
  • Add a column into "statements_summary" and "slow_query" to output the binary plan.
  • Add a global system variable to control if we should generate the binary plan for the execution of a statement.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@time-and-fate
wip
2eac7cf
@time-and-fate
stmt summary, slow query part finish
6e741a1
@time-and-fate
Merge remote-tracking branch 'upstream/master' into visual-plan-s1
ee9a9b8
@time-and-fate
fix
a963ecb
@time-and-fate
fix panic and support explain handling
1df7576
@time-and-fate
update test result
eca0dbc
@time-and-fate
update
c9b9488
@time-and-fate
update tests
dcc5106
@time-and-fate
add comments
794b512
@time-and-fate
add comments
c2fa9b5
@time-and-fate
fix make check
53b3591
@time-and-fate
fix several cases
ef8ff70
@time-and-fate
fix cases
0398c37
@time-and-fate
add comments
ad11d4b
@time-and-fate
fix for cte handling, update test results and optimize memory usage
b12b186
@time-and-fate
Merge remote-tracking branch 'upstream/master' into visual-plan-s1
c514f47
@time-and-fate
simplify code
25d1184
@time-and-fate
remove runtime info from flat plan + small fixes
df54ff2
@time-and-fate
fix lint
e0f1f26
@time-and-fate
small fix for normalize plan and add tests
9aca300
@time-and-fate
fix fmt
a58a271
@time-and-fate
small fixes and add tests
33c276c
@time-and-fate
fix lint
0183259
@time-and-fate
simplify
4f8c549
@time-and-fate
Merge remote-tracking branch 'upstream/master' into visual-plan-s1
ddb73bb
@time-and-fate
move code
3ae9f71
@time-and-fate
add benchmark
e32c01e
@time-and-fate
refactor EXPLAIN code
44f334e
@time-and-fate
small fixes
7b00216
@time-and-fate
fix EXPLAIN FOR in new EXPLAIN code
d1e8fc8
AilinKid
AilinKid reviewed Jul 20, 2022
View reviewed changes
sessionctx/variable/session.go
@@ -2318,6 +2322,10 @@ const (
SlowLogIsWriteCacheTable = "IsWriteCacheTable"
)

// GenerateBinaryPlan decides whether we should record binary plan in slow log and stmt summary.
// It's controlled by the global variable `tidb_generate_binary_plan`.
var GenerateBinaryPlan atomic2.Bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a instance scope or cluster scope?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's cluster scope.
It's controlled by the global scope system variable. Once the system variable is updated, the GenerateBinaryPlan will be updated in all tidb.

AilinKid
AilinKid approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2022
@time-and-fate
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1033132

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
@time-and-fate time-and-fate removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2022
@qw4990
Copy link
Contributor

qw4990 commented Jul 20, 2022

/merge

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
@time-and-fate
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1a111ff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
@time-and-fate
Copy link
Member Author

/run-mysql-test

@ti-chi-bot
Copy link
Member

@time-and-fate: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
@time-and-fate
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0f24af5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2022
@ti-chi-bot ti-chi-bot merged commit a52656f into pingcap:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros winoros approved these changes

@AilinKid AilinKid AilinKid approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make tidb generate binary plan to support the visual plan feature
6 participants
@time-and-fate @ti-chi-bot @sre-bot @qw4990 @winoros @AilinKid