Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: reset PhysicalWindow's schema for mpp plan. #34764

Merged
merged 6 commits into from
May 18, 2022
Merged

planner: reset PhysicalWindow's schema for mpp plan. #34764

merged 6 commits into from
May 18, 2022

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented May 18, 2022 •
edited
Loading

Issue Number: close #34765

see #34765 (comment) for more imformations

  • Manual test (add detailed scripts or steps below)
    before this pr: PhysicalWindow only has 3 output columns.
    after his pr: PhyscialWindow has 5 output columns
None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • fzhedu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed do-not-merge/needs-linked-issue labels May 18, 2022
@LittleFall LittleFall requested review from windtalker and fzhedu May 18, 2022 04:40
@sre-bot
Copy link
Contributor

sre-bot commented May 18, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/eddabbb585224ea238c67e9ec305080569ba77ad

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 18, 2022
@LittleFall LittleFall force-pushed the bugfix/reset-schema branch from 19e44f5 to a1250bc Compare May 18, 2022 06:00
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2022
fzhedu
fzhedu approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2022
windtalker
windtalker approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eddabbb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2022
@LittleFall
Copy link
Contributor Author

/run-mysql-test

@LittleFall LittleFall merged commit 9b1ef78 into pingcap:master May 18, 2022
@LittleFall LittleFall deleted the bugfix/reset-schema branch May 18, 2022 07:00
@sre-bot
Copy link
Contributor

sre-bot commented May 18, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 5 min 57 sec New failing
idc-jenkins-ci-tidb/integration-compatibility-test 🟥 failed 1, success 0, total 1 2 min 49 sec New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 4, success 7, total 11 5 min 13 sec Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 27 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 5 min 58 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 40 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 5 min 31 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 31 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 23 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@fzhedu fzhedu fzhedu approved these changes

@Yisaer Yisaer Yisaer approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Illegal types of arguments (String, Int64) of function equals
6 participants
@LittleFall @ti-chi-bot @sre-bot @windtalker @fzhedu @Yisaer