Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: improve bootstrap code #34755

Merged
merged 7 commits into from
Jun 21, 2022
Merged

session: improve bootstrap code #34755

merged 7 commits into from
Jun 21, 2022

Conversation

morgo
Copy link
Contributor

@morgo morgo commented May 17, 2022

What problem does this PR solve?

Issue Number: close #34754

Problem Summary:

The code for bootstrapping variables is not clean, which makes it a potential source for bugs. This is a function neutral refactor.

What is changed and how it works?

Check List

Tests

  • Unit test (covered by existing tests: we test that variables are written to mysql.global_variables)
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@morgo morgo requested a review from a team as a code owner May 17, 2022 15:20
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2022
@morgo
Copy link
Contributor Author

morgo commented May 17, 2022

Assuming #34644 and #34643 merge - we'll need to add the changes here. Priority should be given to those PRs.

@sre-bot
Copy link
Contributor

sre-bot commented May 17, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/12a7aa9155709a4d6098977035be6cc5f9920294

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2022
@morgo morgo requested review from hawkingrei and bb7133 May 24, 2022 19:46
bb7133
bb7133 approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 1, 2022
@bb7133
Copy link
Member

bb7133 commented Jun 1, 2022

PTAL @hawkingrei

@morgo morgo mentioned this pull request Jun 2, 2022
Merged
4 tasks
@morgo
Copy link
Contributor Author

morgo commented Jun 6, 2022

@hawkingrei ping :-)

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2022
@xhebox
Copy link
Contributor

xhebox commented Jun 21, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5f80cef

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2022
hawkingrei
hawkingrei approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@hawkingrei hawkingrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pong ：）

PTAL

@ti-chi-bot ti-chi-bot merged commit 3b34234 into pingcap:master Jun 21, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 21, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 9 min 40 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 12 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 17 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 16 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 42 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 30 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 1 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo added a commit to morgo/tidb that referenced this pull request Jun 21, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into add-bootstrap-sql
d5c463f 
* upstream/master:
  planner: make some `show stmt` more fine-grained privilege check (pingcap#35493)
  session: improve bootstrap code (pingcap#34755)
  *: upgrade go-proxyprotocol version (pingcap#35560)
  planner: introduce new cost formula for MPPAggs (pingcap#35436)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make bootstrap system variables code cleaner
6 participants
@morgo @ti-chi-bot @sre-bot @bb7133 @xhebox @hawkingrei