Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Auto refresh PD addrs for PDPlacementManager, PDLabelManager, TiFlashPDPlacementManager (#33909) #33915

Closed
wants to merge 1 commit into from
Closed

*: Auto refresh PD addrs for PDPlacementManager, PDLabelManager, TiFlashPDPlacementManager (#33909) #33915

wants to merge 1 commit into from

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 13, 2022 •
edited
Loading

cherry-pick #33909 to release-6.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33915

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/33915:release-6.0-14f4888fb3d7

…TiFlashPDPlacementManager

What problem does this PR solve?

Issue Number: close #33908

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    1. start a tidb cluster with 1 pd
    2. tiup playground scale-out --pd 2
    3. tiup playground scale-in --pid
    4. Execute DDL: create placement policy p1 followers=1;create table t1(a int) placement policy p1
    5. DDL successed
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix bug ddl will not work well when PD member changed

@lcwangchao @ti-srebot
cherry pick pingcap#33909 to release-6.0
d13c154 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 13, 2022
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 13, 2022
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/6.0-cherry-pick labels Apr 13, 2022
@ti-srebot ti-srebot requested review from rleungx, xhebox and Yisaer April 13, 2022 06:22
@sre-bot
Copy link
Contributor

sre-bot commented Apr 13, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/d13c1547e03a9f26a84ba867f9610ae0d070a7ff

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 3, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d13c154

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 4, 2022

/run-unit-test

3 similar comments
@xhebox
Copy link
Contributor

xhebox commented Aug 4, 2022

/run-unit-test

@xhebox
Copy link
Contributor

xhebox commented Aug 4, 2022

/run-unit-test

@xhebox
Copy link
Contributor

xhebox commented Aug 4, 2022

/run-unit-test

@xhebox
Copy link
Contributor

xhebox commented Aug 4, 2022

/merge

1 similar comment
@xhebox
Copy link
Contributor

xhebox commented Aug 4, 2022

/merge

@xhebox
Copy link
Contributor

xhebox commented Aug 4, 2022

/merge

@xhebox
Copy link
Contributor

xhebox commented Aug 4, 2022

Closed, since it is DMN version.
/close

@xhebox xhebox closed this Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@Yisaer Yisaer Yisaer approved these changes

@rleungx rleungx Awaiting requested review from rleungx

Assignees

@lcwangchao lcwangchao

Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @ti-chi-bot @sre-bot @xhebox @Yisaer @lcwangchao