Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: migrate test-infra to testify for testSuiteWithCliBaseCharset #33899

Merged
merged 4 commits into from
Apr 13, 2022
Merged

executor: migrate test-infra to testify for testSuiteWithCliBaseCharset #33899

merged 4 commits into from
Apr 13, 2022

Conversation

tisonkun
Copy link
Contributor

Issue Number: close #33430

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 13, 2022
@tisonkun
Copy link
Contributor Author

/cc @xhebox @hawkingrei

@ti-chi-bot ti-chi-bot requested review from hawkingrei and xhebox April 13, 2022 02:17
@sre-bot
Copy link
Contributor

sre-bot commented Apr 13, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/448b25bf6e2870af2c5a74c191b03123a26f10b2

@hawkingrei
Copy link
Member

@tisonkun Please fix the linter.

@tisonkun
lint
ff880ce 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 13, 2022
@tisonkun
Copy link
Contributor Author

@hawkingrei fixed.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ff880ce

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2022
@ti-chi-bot ti-chi-bot merged commit 3ab2df9 into pingcap:master Apr 13, 2022
@tisonkun tisonkun deleted the issue-33430 branch April 13, 2022 04:44
@purelind
Copy link
Contributor

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-br-test 🟥 failed 27, success 2, total 29 15 min Existing failure
idc-jenkins-ci-tidb/common-test ✅ all 12 tests passed 5 min 28 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 51 min Existing passed
idc-jenkins-ci-tidb/code-coverage 🟢 Lines coverage: 63.48% 12 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/integration-copr-test 🟢 all 1 tests passed 7 min 38 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 44 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 17 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 13 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 4 min 58 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 9 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 51 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@LittleFall LittleFall LittleFall approved these changes

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for executor_test.go testSuiteWithCliBaseCharset
6 participants
@tisonkun @ti-chi-bot @sre-bot @hawkingrei @purelind @LittleFall