-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix panic in upper() and lower() func. (#32505) #32512
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@Defined2014 you're already a collaborator in bot's repo. |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
c464b7b
to
4270555
Compare
PTAL @tangenta @xiongjiwei |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4270555
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c5787c7e1408bdf26de05bdd0231a78524fed07c |
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cherry-pick #32505 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/32512
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #32488
Problem Summary:
Columns.SetRaw
can't be used in upper() and lower(). Because the result of upper() and lower() may not same as before.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note