-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codec: Don't convert set or enum datum to float64 when encoding them (#32308) #32355
codec: Don't convert set or enum datum to float64 when encoding them (#32308) #32355
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@ekexium you're already a collaborator in bot's repo. |
/run-check_dev |
1 similar comment
/run-check_dev |
Please address conflict @ekexium |
@ti-srebot: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PTAL @cfzjywxk @MyonKeminta |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1a8e34ccf32de001b48bbb3908df89d76b869cd5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@TonsnakeLin: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@tiancaiamao: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 76a6414
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #32308 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/32355
After apply modifications, you can push your change to this PR via:
Signed-off-by: ekexium ekexium@gmail.com
What problem does this PR solve?
Issue Number: close #32302
Problem Summary:
When a enum or a set datum is encoded, it's uint64 value is converted to float64 and then converted back to uint64, resulting in the loss of lower bits.
What is changed and how it works?
Use the original
Value
, don't convert.Check List
Tests
Side effects
Documentation
Release note