Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: reorganize in conversion between double and float #31431

Merged
merged 5 commits into from
Jan 7, 2022
Merged

ddl: reorganize in conversion between double and float #31431

merged 5 commits into from
Jan 7, 2022

Conversation

unconsolable
Copy link
Contributor

Signed-off-by: unconsolable chenzhipeng2012@gmail.com

What problem does this PR solve?

Issue Number: close #31372

Problem Summary:

What is changed and how it works?

According to #31372 (comment), change data is necessary for conversion between float and double.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix double column value are different with MySQL after changing column type from float to double

@unconsolable
ddl: reorganize in conversion between double and float
26633cc 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 7, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • Defined2014

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 7, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/96e769a13ed3994bd1bdc0422ec8409c308163c1

@Defined2014
Copy link
Contributor

/run-check_dev_2

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 7, 2022
@unconsolable
Copy link
Contributor Author

/cc @AilinKid
PTAL, thanks.

@ti-chi-bot ti-chi-bot requested a review from AilinKid January 7, 2022 02:46
AilinKid
AilinKid approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 7, 2022
@AilinKid
Copy link
Contributor

AilinKid commented Jan 7, 2022

/cc @AilinKid PTAL, thanks.

Great job! (｡･ω･｡)

@AilinKid AilinKid added the sig/sql-infra SIG: SQL Infra label Jan 7, 2022
@unconsolable
add more test cases
091ae73 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@bb7133
Copy link
Member

bb7133 commented Jan 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 091ae73

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 7, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@ti-chi-bot ti-chi-bot merged commit 4763a70 into pingcap:master Jan 7, 2022
@zimulala zimulala added needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 11, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 11, 2022
@unconsolable @ti-srebot
cherry pick pingcap#31431 to release-5.3
f0f9792 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 11, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #31572

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 11, 2022
@unconsolable @ti-srebot
cherry pick pingcap#31431 to release-5.2
adc8eba 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 11, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #31573

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 11, 2022
@unconsolable @ti-srebot
cherry pick pingcap#31431 to release-5.4
be3d613 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 11, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #31574

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 11, 2022
@unconsolable @ti-srebot
cherry pick pingcap#31431 to release-5.1
d0c8cc1 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 11, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #31575

ti-chi-bot pushed a commit that referenced this pull request Jan 11, 2022
@ti-srebot
ddl: reorganize in conversion between double and float (#31431) (#31574)
c6b217c 
close #31372
@unconsolable unconsolable deleted the issue-31372 branch January 26, 2022 01:49
ti-chi-bot pushed a commit that referenced this pull request Feb 22, 2022
@ti-srebot
ddl: reorganize in conversion between double and float (#31431) (#31572)
e75dc7d 
close #31372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@bb7133 bb7133 bb7133 approved these changes

@AilinKid AilinKid AilinKid approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

double column value are different with MySQL after changing column type from float to double
8 participants
@unconsolable @ti-chi-bot @sre-bot @Defined2014 @AilinKid @bb7133 @ti-srebot @zimulala