-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: Fix data race when getting snapshot ts in IndexLookupJoin and UnionExec (#30487) #31351
executor: Fix data race when getting snapshot ts in IndexLookupJoin and UnionExec (#30487) #31351
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@MyonKeminta you're already a collaborator in bot's repo. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ab9703f
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/51a1c02ca2c84f9413923034e9456be7f4953b0a |
cherry-pick #30487 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/31351
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #30468
Problem Summary: When IndexLookUpJoin builds its inner executors, the building procedure may try to activate the transaction to get the snapshot ts concurrently, causing data race. If we activate the transaction before building inner executors, this problem can be avoided.
It's a quick fix and it's not very elegant since concurrent accessing to the transaction state still exists. I think we'd better to refactor the whole architecture of these executors and the transaction state, however it would be a tough work.
What is changed and how it works?
buildUnionAll
to avoid another similar data race in different threads ofUnionExec
(see Data race when sub-executors of IndexLookUpJoin gets snapshot ts #30468 (comment) )Check List
Tests
Side effects
Documentation
Release note