Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: don't handle collation in in expression if it contains a row function. #31274

Merged
merged 11 commits into from
Jan 6, 2022
Merged

planner: don't handle collation in in expression if it contains a row function. #31274

merged 11 commits into from
Jan 6, 2022

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Jan 4, 2022 •
edited
Loading

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #31273 and close #31300

Problem Summary:
It's vary hard to derive and set the best collation for in expression if it contains a row function.
For example: ("a", ("c", ("d", "e"))) in ("a", ("c" collate bin, ("d", "e" collate general)))
We don't have a good idea to set the collation. So We decide that we don't handle collation in in expression if it contains a row function.

What is changed and how it works?

Don't handle collation in in expression if it contains a row function.
If' acceptable and users rarely depend on it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@wjhuang2016
done
2e26258 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winoros
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2022
@wjhuang2016
fix test
473012b 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 4, 2022
@wjhuang2016 wjhuang2016 added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. type/bugfix This PR fixes a bug. labels Jan 4, 2022
@wjhuang2016
Copy link
Member Author

/run-common-test

@wjhuang2016
reset
8a47ce4 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jan 4, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/77a582e600dcc7131902544f5cb9b08c72040d35

@wjhuang2016
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0816d785212cd7e64d9917af28b04e1ef11577ba

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 5, 2022
@wjhuang2016
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2022
@wjhuang2016
fix
65a0c8e 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 5, 2022
@wjhuang2016
refine
92a549d 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
done
d256c13 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
merge
b5a1923 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 6, 2022
@wjhuang2016
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2022
@wjhuang2016
done
5bf3288 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
Merge branch 'master' into fix_in_mul
6f3a78b
@wjhuang2016
Copy link
Member Author

/run-all-tests

wshwsh12
wshwsh12 approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjhuang2016
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6f3a78b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2022
@wjhuang2016
Copy link
Member Author

/run-check_dev_2

@wjhuang2016
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 5af7685 into pingcap:master Jan 6, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 6, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#31274 to release-5.4
cb5df09 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 6, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #31398

@wshwsh12 wshwsh12 mentioned this pull request Jan 6, 2022
Closed
ti-chi-bot pushed a commit that referenced this pull request Jan 7, 2022
@ti-srebot
planner: don't handle collation in in expression if it contains a r…
1c352ed 
…ow function. (#31274) (#31398)

close #31273, close #31300
@wjhuang2016 wjhuang2016 deleted the fix_in_mul branch November 17, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The results of InStatement and EqualStatement are inconsistent mysql test row failed.
7 participants
@wjhuang2016 @ti-chi-bot @sre-bot @ti-srebot @winoros @wshwsh12 @xiongjiwei