executor: fix CTE bug when used with Apply #31256
Conversation
Signed-off-by: guo-shaoge <shaoge1994@163.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
/cc @wjhuang2016 |
|
/run-unit-test |
| @@ -1392,7 +1392,7 @@ func (s *testPrepareSerialSuite) TestCTE4PlanCache(c *C) { | |||
| tk.MustExec("set @a=1, @b=2, @c=3, @d=4, @e=5, @f=0;") | |||
|
|
|||
| tk.MustQuery("execute stmt using @f, @a, @f").Check(testkit.Rows("1")) | |||
| tk.MustQuery("execute stmt using @a, @b, @a").Check(testkit.Rows("1")) | |||
| tk.MustQuery("execute stmt using @a, @b, @a").Sort().Check(testkit.Rows("1", "2")) | |||
| tk.MustQuery("select @@last_plan_from_cache;").Check(testkit.Rows("0")) | |||
There was a problem hiding this comment.
The correct result is '1 2':
drop table if exists t1;
create table t1(a int);
insert into t1 values(1);
insert into t1 values(2);
SELECT * FROM t1 dt WHERE EXISTS(WITH RECURSIVE qn AS (SELECT a*1 AS b UNION ALL SELECT b+2 FROM qn WHERE b=1) SELECT * FROM qn WHERE b=a);
|
/run-unit-test |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
|
/cc @qw4990 |
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/314c19890a462879de9e66bcdbc5bae97bf5f6de |
|
/run-check_dev_2 |
|
/run-mysql-test |
|
/run-mysql-test |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 6fea0fe
|
|
/run-check_dev_2 |
|
/run-unit-test |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.1 in PR #31380 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.2 in PR #31381 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.3 in PR #31382 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.4 in PR #31383 |
What problem does this PR solve?
Issue Number: close #31255
Problem Summary: No handling for Apply.
What is changed and how it works?
Add
IsInApplyinCTEClassto indicates whether CTE is the inner plan of Apply. If it is,CTEExec.resTblandCTEExec.iterInTblwill be reset for each outer row of Apply.Check List
Tests
Side effects
Documentation
Release note