-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: fix build ranger's collation #31226
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-check_dev_2 |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2775c0f192c28f8712f6d0d4993509f25ea8aac8 |
/run-check_dev_2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 58ac106
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.4 in PR #31268 |
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: close #31216
Problem Summary:
When building range for scalarfunction, we should not use
expr.CharsetAndCollation()
to get the collation.For
col1 > 'a' or col1 >'b'
, it always gets binCollation.So we need to pass collation to Build().
What is changed and how it works?
Pass column's collation to Build() and use it.
Check List
Tests
Side effects
Documentation
Release note