Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topsql: make topsql enable only be controlled by pub/sub sink #31209

Merged
merged 15 commits into from
Dec 31, 2021
Merged

topsql: make topsql enable only be controlled by pub/sub sink #31209

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c695bf1
topsql: make topsql enable only be controlled by pub/sub sink
crazycs520 Dec 31, 2021
6e40915
refine test
crazycs520 Dec 31, 2021
821fc84
Merge branch 'master' into topsql-enable
crazycs520 Dec 31, 2021
8881f5e
address comment
crazycs520 Dec 31, 2021
0f2d081
Merge branch 'master' into topsql-enable
crazycs520 Dec 31, 2021
ac6471c
Merge branch 'master' into topsql-enable
ti-chi-bot Dec 31, 2021
1c3249b
fix test
crazycs520 Dec 31, 2021
fa1246b
Merge branch 'master' into topsql-enable
crazycs520 Dec 31, 2021
82c1ec4
update test comment
crazycs520 Dec 31, 2021
75b04d9
Merge branch 'topsql-enable' of https://github.com/crazycs520/tidb in…
crazycs520 Dec 31, 2021
a3f7178
fix test
crazycs520 Dec 31, 2021
4bfbd23
Merge branch 'master' into topsql-enable
crazycs520 Dec 31, 2021
be0ce88
Merge branch 'master' into topsql-enable
ti-chi-bot Dec 31, 2021
16c494e
Merge branch 'master' into topsql-enable
crazycs520 Dec 31, 2021
83ae59e
Merge branch 'master' into topsql-enable
crazycs520 Dec 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion executor/set_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1602,5 +1602,5 @@ func (s *testSerialSuite) TestSetTopSQLVariables(c *C) {

// Test for hide top sql variable in show variable.
tk.MustQuery("show variables like '%top_sql%'").Check(testkit.Rows())
tk.MustQuery("show global variables like '%top_sql%'").Check(testkit.Rows())
tk.MustQuery("show global variables like '%top_sql%'").Check(testkit.Rows("tidb_enable_top_sql OFF"))
}