Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Print readable log with stack trace when TestCheckFailReport fails #30897

Merged

Conversation

MyonKeminta
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #26833

Problem Summary: We've met TestCheckFailReport fail on CI due to log number mismatch, but with unreadable output which makes it hard to find out the reason. This PR makes it print readable log when the log number mismatch, and also added stack trace to the related logs. So it would make it easier to diagnose the problem in the future.

What is changed and how it works?

Check List

Tests

  • Unit test

Side effects

Documentation

  • None

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 21, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • ekexium

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@MyonKeminta MyonKeminta requested a review from cfzjywxk December 21, 2021 05:22
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2021
@MyonKeminta MyonKeminta requested a review from ekexium December 21, 2021 06:10
@MyonKeminta
Copy link
Contributor Author

/run-check_dev

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 21, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 21, 2021
@MyonKeminta MyonKeminta merged commit 44479df into pingcap:ft-data-inconsistency Dec 21, 2021
@MyonKeminta MyonKeminta deleted the m/log-print-stack branch December 21, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants