-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: fix gcs max key limit (#30393) #30560
lightning: fix gcs max key limit (#30393) #30560
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@Leavrth please accept the invitation then you can push to the cherry-pick pull requests. Comment with |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: cbc9e3b
|
/run-check_dev |
1 similar comment
/run-check_dev |
cherry-pick #30393 to release-5.3
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/30560
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #30377
Problem Summary:
opt.ListCount
is the number of keys fetched each time for s3, instead of the limitation.What is changed and how it works?
ignore
opt.ListCount
in gcs and directly walk all the keys.Check List
Tests
Side effects
Documentation
Release note