Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix nil pointer dereference for case expression #30479

Merged
merged 6 commits into from
Jan 5, 2022
Merged

expression: fix nil pointer dereference for case expression #30479

merged 6 commits into from
Jan 5, 2022

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Dec 7, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #30245

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix nil pointer dereference for case expression

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 7, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2021
@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

2 similar comments
@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2021
@xiongjiwei xiongjiwei changed the title epxression: case epxression: fix nil point dereference for case expression Dec 8, 2021
@xiongjiwei xiongjiwei marked this pull request as ready for review December 8, 2021 07:11
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 8, 2021
@xiongjiwei xiongjiwei changed the title epxression: fix nil point dereference for case expression epxression: fix nil pointer dereference for case expression Dec 8, 2021
@xiongjiwei xiongjiwei requested review from wshwsh12, xhebox, hawkingrei and wjhuang2016 and removed request for xhebox December 8, 2021 07:13
zimulala
zimulala reviewed Dec 8, 2021
View reviewed changes
@xiongjiwei xiongjiwei changed the title epxression: fix nil pointer dereference for case expression expression: fix nil pointer dereference for case expression Dec 8, 2021
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 8, 2021
@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 13, 2021
bb7133
bb7133 reviewed Dec 27, 2021
View reviewed changes
bb7133
bb7133 reviewed Dec 27, 2021
View reviewed changes
@xiongjiwei xiongjiwei force-pushed the case-when-collation branch from 9684364 to cd6ebaf Compare January 4, 2022 02:17
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 4, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/36753e62c47b4e3e9a7e3abf1a531afd9ddd08e5

@xiongjiwei xiongjiwei added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Jan 4, 2022
bb7133
bb7133 approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2022
@bb7133
Copy link
Member

bb7133 commented Jan 4, 2022

PTAL @wjhuang2016

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 4, 2022
@bb7133
Copy link
Member

bb7133 commented Jan 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e92d726

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 5, 2022
@ti-chi-bot ti-chi-bot merged commit d9d89d6 into pingcap:master Jan 5, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 5, 2022
@xiongjiwei @ti-srebot
cherry pick pingcap#30479 to release-5.4
470c0d4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 5, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #31305

ti-chi-bot pushed a commit that referenced this pull request Jan 6, 2022
@ti-srebot
expression: fix nil pointer dereference for case expression (#30479) (#…
ac75188 
…31305)

close #30245
@xiongjiwei xiongjiwei deleted the case-when-collation branch September 23, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

@xhebox xhebox Awaiting requested review from xhebox

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

different error code with mysql in mix of collations
7 participants
@xiongjiwei @ti-chi-bot @sre-bot @bb7133 @ti-srebot @zimulala @wjhuang2016