Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

privilege: fix grant and revoke for global level grant(#29675) #29899

Merged
merged 4 commits into from
Nov 24, 2021
Merged

privilege: fix grant and revoke for global level grant(#29675) #29899

merged 4 commits into from
Nov 24, 2021

Conversation

yiwen92
Copy link
Contributor

@yiwen92 yiwen92 commented Nov 18, 2021

What problem does this PR solve?

Issue Number: close #29675

Problem Summary:
Fix grant and revoke for global level grant in information schema.

What is changed and how it works?

When sql contain global level grant like ., do not fill dbName, this can skip privilege check in later and execute successfully without error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

This is a fix for grant global level case in v4.0 and v5.0

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 18, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2021
@yiwen92
Copy link
Contributor Author

yiwen92 commented Nov 19, 2021

/cc @morgo

@ti-chi-bot ti-chi-bot requested a review from morgo November 19, 2021 09:46
@yiwen92
Copy link
Contributor Author

yiwen92 commented Nov 19, 2021

/assignee @yiwen92

@yiwen92
Copy link
Contributor Author

yiwen92 commented Nov 19, 2021

/cc @bb7133 PTAL,thx

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 22, 2021
@tiancaiamao
Copy link
Contributor

PTAL @morgo

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 22, 2021
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 24, 2021
@VelocityLight
Copy link

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 00b768a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 24, 2021
@ti-chi-bot
Copy link
Member

@yiwen92: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 051ca86 into pingcap:release-4.0 Nov 24, 2021
@zhouqiang-cl zhouqiang-cl added this to the v4.0.16 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants