-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: enable mutation checker for any store type #29654
session: enable mutation checker for any store type #29654
Conversation
Signed-off-by: ekexium <ekexium@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
/run-check_title |
/run-check_dev |
1 similar comment
/run-check_dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to use two configurations for mutation checker
and assertion checker
, or one consistency checker
?
@cfzjywxk I suggest separate them for now, until when we find assertion can be used in production environments. By the way, there is already a variable controlling assertion in my PR. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0792dc6
|
Signed-off-by: ekexium ekexium@gmail.com
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
The mutation checker should be enabled for tests without TiKV.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note