*: add support for --initialize-secure and --initialize-insecure #28487
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
| logutil.BgLogger().Fatal("failed to read current user. unable to secure bootstrap.", zap.Error(err)) | ||
| } | ||
| mustExecute(s, `INSERT HIGH_PRIORITY INTO mysql.user VALUES | ||
| ("localhost", "root", %?, "auth_socket", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "N", "Y", "Y", "Y", "Y", "Y", "Y", "Y")`, u.Username) |
There was a problem hiding this comment.
What about Windows? there "auth_socket" won't work.
There was a problem hiding this comment.
I will add a check for windows and refuse to use secure bootstrap.
There was a problem hiding this comment.
@dveeden I've added validation to the option so it is not supported on Windows. PTAL again.
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: a707103
|
|
@morgo: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #28485
Problem Summary:
This provides support for
--initialize-secureand--initialize-insecureoptions. The default remains unchanged.What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Check List
Tests
Side effects
Documentation
Release note