Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: generate addition selection when plan cache enable #28457

Merged
merged 17 commits into from
Sep 29, 2021
Merged

planner: generate addition selection when plan cache enable #28457

merged 17 commits into from
Sep 29, 2021

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Sep 28, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #28259

Problem Summary:
When plan cache is available, we may eliminate Selection when generating RangeScan, but it will cause errors when parameter values are changed.

What is changed and how it works?

Add the eliminated selection.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

'None'

@Reminiscent Reminiscent added type/bugfix This PR fixes a bug. sig/planner SIG: Planner epic/plan-cache affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. labels Sep 28, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2021
qw4990
qw4990 reviewed Sep 29, 2021
View reviewed changes
planner/core/find_best_task.go Outdated
Comment on lines 1634 to 1638
// keepAccessCondsAsFilter4PlanCache is used to keep the access conditions as
// filter conditions when the following conditions are met:
// 1. Access conditions contains the lazy constant, see the MaybeOverOptimized4PlanCache
// function for more details.
func keepAccessCondsAsFilter4PlanCache(ctx sessionctx.Context, accessConds []expression.Expression, filterConds []expression.Expression) []expression.Expression {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an example in its comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 29, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 29, 2021
@rebelice
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6aaaf24

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 29, 2021
@ti-chi-bot ti-chi-bot merged commit 091ae3b into pingcap:master Sep 29, 2021
@Reminiscent Reminiscent deleted the issue#28259 branch September 29, 2021 09:31
@Reminiscent Reminiscent mentioned this pull request Oct 11, 2021
Merged
12 tasks
@zimulala
Copy link
Contributor

@Reminiscent Do we need to cherry-pick to 5.2？

@Reminiscent Reminiscent removed affects-4.0 This bug affects 4.0.x versions. affects-5.0 This bug affects 5.0.x versions. affects-5.1 This bug affects 5.1.x versions. affects-5.2 This bug affects 5.2.x versions. labels Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@rebelice rebelice rebelice approved these changes

Assignees
No one assigned
Labels
epic/plan-cache release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prepared-plan-cache: return wrong result using bigint column
5 participants
@Reminiscent @ti-chi-bot @rebelice @zimulala @qw4990