Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: migrate test-infra to testify for format_test.go #28083

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

dswij
Copy link
Contributor

@dswij dswij commented Sep 16, 2021

What problem does this PR solve?

close #28005

Problem Summary: N/A

What is changed and how it works?

What's Changed: Test in format_test.go now uses testify instead

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • mmyj

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Sep 16, 2021
@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 16, 2021
@CLAassistant
Copy link

CLAassistant commented Sep 16, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 16, 2021
@ti-chi-bot
Copy link
Member

Welcome @dswij!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@sre-bot
Copy link
Contributor

sre-bot commented Sep 16, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@dswij dswij changed the title types: migrate test-infra to testify for format_test.go types: migrate test-infra to testify for format_test.go Sep 16, 2021
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 16, 2021
This commit updates assertion for `format_test.go` to use `testify`
instead.
@dswij dswij force-pushed the testify-format-test branch from 4090e6f to 7a0147b Compare September 16, 2021 06:26
@dswij
Copy link
Contributor Author

dswij commented Sep 16, 2021

/run-check_title

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2021
Copy link
Member

@mmyj mmyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 16, 2021
@mmyj
Copy link
Member

mmyj commented Sep 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f911bc2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2021
@ti-chi-bot
Copy link
Member

@dswij: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@karuppiah7890
Copy link
Contributor

testTimeSuite in

type testTimeSuite struct {
is used in https://github.com/pingcap/tidb/blob/a84ceb801fe82e931cc4a454c5081c67ba9d064c/types/format_test.go which this PR removes. I'll wait for this PR to be merged to merge the PR for the issue #28010

@ti-chi-bot ti-chi-bot merged commit 56da9b9 into pingcap:master Sep 16, 2021
@dswij dswij deleted the testify-format-test branch September 16, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for format_test.go
8 participants