Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: fix wrong convert from string to enum #27629

Merged
merged 5 commits into from
Aug 27, 2021
Merged

util: fix wrong convert from string to enum #27629

merged 5 commits into from
Aug 27, 2021

Conversation

wshwsh12
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #27610

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

Please add a release note, or a 'None' if it is not needed.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2021
@wshwsh12
Copy link
Contributor Author

/run-all-tests

@wshwsh12
Copy link
Contributor Author

/run-integration-tests

@wshwsh12 wshwsh12 requested review from lzmhhh123 and ichn-hu August 27, 2021 03:52
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 27, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 27, 2021
@wshwsh12
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f3ce8c3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 27, 2021
@github-actions github-actions bot added the sig/planner SIG: Planner label Aug 27, 2021
@ti-chi-bot ti-chi-bot merged commit fabfc22 into pingcap:master Aug 27, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 27, 2021
@wshwsh12 @ti-srebot
cherry pick pingcap#27629 to release-5.1
0cce598 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 27, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #27631

@ti-srebot ti-srebot mentioned this pull request Aug 27, 2021
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 27, 2021
@wshwsh12 @ti-srebot
cherry pick pingcap#27629 to release-5.2
b031d8f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27632

ti-chi-bot pushed a commit that referenced this pull request Aug 27, 2021
@ti-srebot
util: fix wrong convert from string to enum (#27629) (#27632)
05d2210
ti-chi-bot pushed a commit that referenced this pull request Sep 17, 2021
@ti-srebot
util: fix wrong convert from string to enum (#27629) (#27631)
d67969c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@ichn-hu ichn-hu ichn-hu approved these changes

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong result when using index in enum column
5 participants
@wshwsh12 @ti-chi-bot @ti-srebot @lzmhhh123 @ichn-hu