util/rowcodec: migrate test-infra to testify #27525
Conversation
Signed-off-by: tison <wander4096@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
@tisonkun: GitHub didn't allow me to request PR reviews from the following users: UBarney. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| false, | ||
| }, | ||
| for _, test := range tests { | ||
| t.Run(test.name, func(t *testing.T) { |
There was a problem hiding this comment.
the body of t.Run is from encodeAndDecodeHandle with trivial rename or gocheck to testify.
|
/run-check_dev_2 |
|
/run-check_dev_2 |
|
/assign @xhebox @tiancaiamao could you please help on merging this PR? |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 1dd220b
|
|
@tisonkun: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: tison wander4096@gmail.com
What problem does this PR solve?
Issue Number: close #26413
This PR is based on #27048, please refer to previous discussion first if you have any question.
Release note