Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionctx/stmtctx: migrate test-infra to testify for sessionctx/stmtctx #27280 #27504

Merged
merged 2 commits into from
Aug 24, 2021
Merged

sessionctx/stmtctx: migrate test-infra to testify for sessionctx/stmtctx #27280 #27504

merged 2 commits into from
Aug 24, 2021

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #27280

Problem Summary: migrate test-infra to testify for sessionctx/stmtctx

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 23, 2021
@Defined2014
Copy link
Contributor Author

/cc tisonkun

@ti-chi-bot ti-chi-bot requested a review from tisonkun August 23, 2021 08:53
@Defined2014 Defined2014 requested a review from qw4990 August 23, 2021 09:30
tisonkun
tisonkun approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tisonkun
Copy link
Contributor

/cc @morgo

@ti-chi-bot ti-chi-bot requested a review from morgo August 23, 2021 09:37
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2021
@morgo
Copy link
Contributor

morgo commented Aug 23, 2021

/merge

@ti-chi-bot
Copy link
Member

@morgo: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Defined2014
Copy link
Contributor Author

/retest

@Defined2014
Copy link
Contributor Author

/run-all-tests

@Defined2014 Defined2014 requested a review from bb7133 August 24, 2021 02:09
@Defined2014
Copy link
Contributor Author

/run-unit-test

4 similar comments
@Defined2014
Copy link
Contributor Author

/run-unit-test

@Defined2014
Copy link
Contributor Author

/run-unit-test

@Defined2014
Copy link
Contributor Author

/run-unit-test

@Defined2014
Copy link
Contributor Author

/run-unit-test

@Defined2014 Defined2014 requested a review from zimulala August 24, 2021 03:38
zimulala
zimulala approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 24, 2021
@zimulala
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9684f3b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 24, 2021
@ti-chi-bot ti-chi-bot merged commit 25940d4 into pingcap:master Aug 24, 2021
@Defined2014 Defined2014 deleted the issue-#27280 branch August 24, 2021 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

@zimulala zimulala zimulala approved these changes

@tisonkun tisonkun tisonkun approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for sessionctx/stmtctx
5 participants
@Defined2014 @ti-chi-bot @tisonkun @morgo @zimulala