Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: migrate test-infra to testify #26882

Merged
merged 10 commits into from
Aug 13, 2021
Merged

meta: migrate test-infra to testify #26882

merged 10 commits into from
Aug 13, 2021

Conversation

yedamao
Copy link
Contributor

@yedamao yedamao commented Aug 4, 2021

What problem does this PR solve?

Issue Number: close #26740

Release note 

None.

yedamao added 2 commits August 4, 2021 11:40
@yedamao
meta: migrate test-infra to testify (part I)
9c2a138
@yedamao
meta: migrate TestDDL to testify
d39ed2d 
- replace `util/testutil.CommonHandleSuite.RerunWithCommonHandleEnabled`
  with table driven test cases (with IntHandle and CommonHandle).
- make `Test for add index job` as splitted subtest, to avoid rerun.
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 4, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 4, 2021
@yedamao
Copy link
Contributor Author

yedamao commented Aug 4, 2021

/cc @tisonkun
Please take a look.

I made some change in the TestDDL.

  • replace util/testutil.CommonHandleSuite.RerunWithCommonHandleEnabled
    with table driven test cases (with IntHandle and CommonHandle).
  • make Test for add index job as splitted subtest, to avoid rerun.

@ti-chi-bot ti-chi-bot requested a review from tisonkun August 4, 2021 06:00
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Aug 4, 2021
tisonkun added 6 commits August 4, 2021 19:46
@tisonkun
style
18f95e0 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
better matcher
e92eb22 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
split TestAddIndexJob
7a572a0 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
simple desc
6cc0f5b 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
avoid label
0375ce8 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
run in parallel
788214d 
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
tisonkun approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I push a few follow ups as commit message describe.

You can take a look at whether it is follow your opinion.

LGTM.

@ti-chi-bot
Copy link
Member

@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Thanks for your contribution! I push a few follow ups as commit message describe.

You can take a look at whether it is follow your opinion.

LGTM.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yedamao
Copy link
Contributor Author

yedamao commented Aug 4, 2021

@tisonkun Thanks for your help.

@tisonkun
Copy link
Contributor

tisonkun commented Aug 4, 2021

/cc @xhebox @tiancaiamao

PTAL

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2021
@tisonkun
Copy link
Contributor

/cc @xiongjiwei @tangenta

PTAL. Thanks!

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 13, 2021
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 78b0451

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 13, 2021
@ti-chi-bot
Copy link
Member

@yedamao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yedamao
Copy link
Contributor Author

yedamao commented Aug 13, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 0f2762b into pingcap:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@xhebox xhebox xhebox approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for meta pkg
5 participants
@yedamao @ti-chi-bot @tisonkun @xiongjiwei @xhebox