Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: migrate test-infra to testify (part 2) #26752

Merged
merged 14 commits into from
Aug 3, 2021
Merged

domain: migrate test-infra to testify (part 2) #26752

merged 14 commits into from
Aug 3, 2021

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Jul 30, 2021 •
edited
Loading

Signed-off-by: tison wander4096@gmail.com

What problem does this PR solve?

Issue Number: close #26306

split from #26307 , [2/2]

based on #26751

None

tisonkun added 4 commits July 28, 2021 15:52
@tisonkun
domain: migrate test-infra to testify (part 0)
a95118d 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Merge branch 'master' into domain-part-0
c6314ee
@tisonkun
domain: migrate test-infra to testify (part 1)
6d47885 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
domain: migrate test-infra to testify (part 2)
b5056d5 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested review from tiancaiamao and xhebox July 30, 2021 08:58
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 30, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tiancaiamao
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 30, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jul 30, 2021
@xhebox
Copy link
Contributor

xhebox commented Aug 2, 2021

I will review it after part1 merged.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2021
@xhebox
Copy link
Contributor

xhebox commented Aug 2, 2021

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2021
@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 3, 2021

/run-all-tests

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 3, 2021

/run-check_dev_2

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 3, 2021

/run-unit-test

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 3, 2021

/run-all-tests

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 3, 2021

/run-all-tests

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 3, 2021

/run-all-tests

1 similar comment
@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 3, 2021

/run-all-tests

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 3, 2021

/merge cancel

It seems something wrong happened. Let me dig a abit.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2021
@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 3, 2021

It seems failpoints conflict with each others. Let me batch domain_test to run in serial.

@tisonkun
domain: handle serial tests
d4b3eb1 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 3, 2021 •
edited
Loading

/cc @xhebox @tiancaiamao

May you give another review and move to merge?

the last significant commit is d4b3eb1

@xhebox
Copy link
Contributor

xhebox commented Aug 3, 2021

LGTM, failpoints and global config are both serial-safe, maybe mention it in the tracking issue.

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 3, 2021

@xhebox will update it.

Please help on /merge as I /merge cancel when debugging...

@tisonkun tisonkun mentioned this pull request Aug 3, 2021
Closed
53 tasks
@xhebox
Copy link
Contributor

xhebox commented Aug 3, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d4b3eb1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2021
@ti-chi-bot ti-chi-bot merged commit bf7e353 into pingcap:master Aug 3, 2021
@tisonkun tisonkun deleted the domain-part-2 branch August 3, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for domain pkg
4 participants
@tisonkun @ti-chi-bot @xhebox @tiancaiamao