-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: merge BR into TiDB #26655
*: merge BR into TiDB #26655
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@3pointer may we create an issue to describe the step? I think it is nit to have a proposal but an issue it necessary. |
I'd regard forum post as a pre discussion to gather suggestion. |
/run-unit-tests |
0eff247
to
667f6c1
Compare
8cc826c
to
c79c3f6
Compare
/run-integration-tests |
bbc6216
to
9f60546
Compare
@3pointer is it true that we don't need a release note for this change? I think it changes BR import path at least. |
96ea84f
to
368152b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and some hints for the following reviewers:
- Among the ~200 files, most of them are trivial import path fix, don't panic.
- The non-trivial changes are mainly clustered at project config files, say,
Makefile
,log.go
, etc..
/run-check_dev_2 |
d0837d3
to
d2b005e
Compare
/run-check_dev_2 |
1e5ab88
to
8140871
Compare
8140871
to
479dd2b
Compare
@wjhuang2016 @YuJuncen if this PR is good to go, would you mind to help on merging? |
IMHO there are several next step TODOs:
But they are not related to code engineering itself, we do not have to finish it in this PR. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 049a8e1
|
@3pointer: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #26880
Problem Summary: Merge BR repo into TiDB. and resolve the cycle dependence in BR and TiDB.
What is changed and how it works?
Don't review this PR. because it has the whole br repo files change.
Review 3pointer#2 instead.
This PR is used to trigger CI.
Check List
Tests
Release note